Staffan,
Technically, the fix look OK for me.
But,
executeJCmd("ManagementAgent.start_local").close();
looks a bit weird for me.
It might be better to create something like
executeJCmd_no_out();
-Dmitry
On 2014-09-08 16:25, Staffan Larsen wrote:
> Two fixes:
> - The PipedInputStream used by the attach code on windows is not closed in
> case of errors
> - The InputStreams returned by VirtualMachine.execute are not closed by all
> callers
>
> webrev: http://cr.openjdk.java.net/~sla/8057558/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8057558
>
> Thanks,
> /Staffan
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
