On 13/11/2014 13:56, Mikael Auno wrote:
Hi,
Could I please get a review of this addition of SVC tests to JPRT submit
jobs. So far, I'm only adding JDI tests as those are the only ones I
have completed code coverage analysis on to determine the best subset to
add. The other areas will be added too, but I'm adding these now to get
the ball rolling asap.
I've run these through JPRT once already without failures and have got
two more runs in the pipe. I've also looked through the history for
these tests and found that they do not have any known instabilities to
worry about.
Issue: https://bugs.openjdk.java.net/browse/JDK-8064799
Webrev: http://cr.openjdk.java.net/~miauno/8064799/webrev.00/
This doesn't look very maintainable. If we are adding *_sanity groups
then would be better to move them to their own section of the file so
that they are in the middle of the main grouping of the tests? Also I
think we should avoid list individual tests if we can, would it be
better to leave out JDI until your analysis is completed?
-Alan
