Hi Katja,
test/ProblemList.txt - you are adding seemingly unrelated issue here
test/sun/tools/jinfo/JInfoHelper.java
L68 - processBuilder.command(...) could be moved to L67 and do new
ProcessBuilder(launcher.getCommand()) - it communicates the purpose better
Cheers,
-JB-
On 11/18/2014 12:07 PM, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
In this fix I take an opportunity to refactor sun/tools/jinfo/Basic.sh
and to add more tests for jinfo utility. sun/tools/jinfo/Basic.sh is a
last unstable test among tests listed
inhttps://bugs.openjdk.java.net/browse/JDK-6542634 that's why I've
chosen to use this bug number instead of creating a new one.
bug: https://bugs.openjdk.java.net/browse/JDK-6542634
webrev: http://cr.openjdk.java.net/~ykantser/6542634/webrev.00/
The tests have been run and passed on all basic platforms.
Thanks,
Katja
