On 05/07/2015 05:32 PM, Dmitry Samersoff wrote: > Andrew, > > Looks good, except couple of minor nits. > > Please, take a look at LinuxAARCH64CFrame.java:70, > it might be a bug - probably, you should check against fp, > not rsp here. > > See also below. > > LinuxDebuggerLocal.c: > > 375: Please, use NPRGREG from AARCH64ThreadContext.java, > the same way as other platforms does.
OK. > HSDB.java > > 998: it's better to add String cpu = VM.getVM().getCPU(); > and shorten if. OK. > But JDK 7 and later doesn't support Itanium, so you can remove this if > entirely. > > LinuxAARCH64CFrame.java: > > 60 - please, remove space after/before brackets. > 65,69,73 - please, remove space after bracket. > 65 - it's better to add brackets around 2 * ADDRESS_SIZE OK. This is all stuff inherited from x86. > 70 - probably, you should check against fp, not rsp here. Hmmm. I would have thought it's a good sanity check either way. > RemoteAARCH64ThreadContext.java: > > 40, 46 Please,remove stale comments. OK. > LinuxAARCH64JavaThreadPDAccess.java: > > 67 and below - only one space should be after public OK. Again, it's all inherited from x86 and I didn't want to make any unnecessary whitespace changes, but OK. Thanks, Andrew.
