Hi Alan, thanks for your quick turnaround on this.
I updated Transport.java and Connection.java to get the class descriptions more compact: http://cr.openjdk.java.net/~clanger/webrevs/8181417.1/ Let me know where you find the blank lines reformatting odd. I tried to follow the usual layout that after the opening brace of a class a blank line would follow, as well as in between methods and fields one empty line should be placed. Other than that, can I consider this reviewed? Thanks Christoph From: Alan Bateman [mailto:[email protected]] Sent: Donnerstag, 1. Juni 2017 11:59 To: Langer, Christoph <[email protected]>; [email protected] Subject: Re: JDK 10 RFR 8181417: Code cleanups in com.sun.jdi On 01/06/2017 10:39, Langer, Christoph wrote: Hi, during integration work of the jdi library for one of our projects I spotted some places where a few cleanups could be done. I'd like to contribute this. It is mostly about import statements and formatting/empty lines. I think at this stage of JDK10 it's a good time for such kind of work. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8181417.0/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8181417.0/> Bug: https://bugs.openjdk.java.net/browse/JDK-8181417 serviceability-dev is the right place so dropping core-libs-dev. In Transport, maybe Connection too, then the class description looks very messy now so I think that needs to reformatted so that lines are roughly of equal length. The reformatting and adding/removing blank lines looks odd in places but not worth discussing. -Alan
