Hi Langer,

Thank you for the contribution!
It looks good (agreed with Alan on a lot of noise with the adding/removing empty lines).
Many files (including new in this version of webrev) miss the copyright comment update.

Thanks,
Serguei



On 6/1/17 08:38, Langer, Christoph wrote:

Hi again,

 

I updated my webrev to include packages com.sun.jdi.event and com.sun.jdi.request as well. With that I’ve added everything that I found in com.sun.jdi and its subpackages.

 

Please look here: http://cr.openjdk.java.net/~clanger/webrevs/8181417.1/

 

Best regards

Christoph

 

From: Langer, Christoph
Sent: Donnerstag, 1. Juni 2017 11:40
To: [email protected]; [email protected]
Subject: JDK 10 RFR 8181417: Code cleanups in com.sun.jdi

 

Hi,

 

during integration work of the jdi library for one of our projects I spotted some places where a few cleanups could be done. I’d like to contribute this. It is mostly about import statements and formatting/empty lines. I think at this stage of JDK10 it’s a good time for such kind of work.

 

Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8181417.0/

Bug: https://bugs.openjdk.java.net/browse/JDK-8181417

 

Thanks and best regards

Christoph

 


Reply via email to