Re: CSR review request for: 8187289 NotifyFramePop request is not cleared if JVMTI_EVENT_FRAME_POP is disabled

[Chris Plummer]

Hi Serguei, I've read through it and it looks fine except for one minor thing: "The solution is to clear all bound NotifyFramePop requests when a stack frame is popped." I think this could be made more clear. It makes it sound like you clear *all* NotifyFramePop requests the first time *any* frame is popped. This is the first time I've dealt with a CSR. What do I need to do to mark it reviewed? thanks, Chris On 11/16/17 4:25 PM, serguei.spit...@oracle.com wrote: Dan and Chris Could one of you, please, review the CSR for 8187289:   https://bugs-stage.openjdk.java.net/browse/JDK-8191098 Bug is:   https://bugs-stage.openjdk.java.net/browse/JDK-8187289 Approved webrev:   http://cr.openjdk.java.net/%7Esspitsyn/webrevs/2017/hotspot/8187289-jvmti-framepop.2/ This CSR covers a change in behavior, not in the JVMTI spec. We decided that the JVMTI NotifyFramePop is intuitive enough and does not need an update. Thanks, Serguei