On 11/16/17 21:40, serguei.spit...@oracle.com wrote:
On 11/16/17 18:23, David Holmes wrote:
On 17/11/2017 12:00 PM, serguei.spit...@oracle.com wrote:
Hi David,
I've to leave now for a couple of hours.
I've created the CSR from the real bug report, but don't know
anything about the bugs-stage.
A link "csr for" was auto-added when the CSR was created.
You must have done that while looking at the bug on bugs-stage.
Most likely.
But it is unclear how I've got there. :(
The real bug:
https://bugs.openjdk.java.net/browse/JDK-8187289
Ok.
I'll create the CSR once more.
The CSR is:
https://bugs.openjdk.java.net/browse/JDK-8191467
I've added Chris and Dan as reviewers and changed the state to "Proposed".
Not sure, how it should switch to the "Pended" state.
Thanks,
Serguei
Thank you for catching this problem, David!
Thanks,
Serguei
has no CSR.
David
Thanks,
Serguei
On 11/16/17 17:53, David Holmes wrote:
The CSR needs to be created again from the real bug report.
Everyone will need to re-review and re-add any necessary comments.
David
On 17/11/2017 11:51 AM, David Holmes wrote:
On 17/11/2017 10:25 AM, serguei.spit...@oracle.com wrote:
Dan and Chris
Could one of you, please, review the CSR for 8187289:
https://bugs-stage.openjdk.java.net/browse/JDK-8191098
Bug is:
https://bugs-stage.openjdk.java.net/browse/JDK-8187289
The links above should not be to bugs-stage!
David
Approved webrev:
http://cr.openjdk.java.net/%7Esspitsyn/webrevs/2017/hotspot/8187289-jvmti-framepop.2/
This CSR covers a change in behavior, not in the JVMTI spec.
We decided that the JVMTI NotifyFramePop is intuitive enough and
does not need an update.
Thanks,
Serguei
