Hi Alex, as far as I know, it's not possible to include hotspot headers in the JDK, so we have to leave it local.
Best regards Christoph -----Original Message----- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Alex Menkov Sent: Donnerstag, 7. Dezember 2017 21:16 To: Chris Plummer <chris.plum...@oracle.com>; serviceability-dev@openjdk.java.net Subject: Re: RFR (XS): 8193183: Fix format string in libdt_shmem/shmemBase.c well, maybe code duplication is lesser evil in the case :) --alex On 12/07/2017 11:25, Chris Plummer wrote: > I had noticed that when I first looked at these changes, but figured > that JDI code cannot leverage globalDefinitions.hpp. However, I'm not > certain of that. > > Chris > > On 12/7/17 10:50 AM, Alex Menkov wrote: >> Looks like we already have definitions to workaround Visual Studio >> issues (including absence of PRId64) in >> open/src/hotspot/share/utilities/globalDefinitions_visCPP.hpp >> It would be better to reuse it (to have all workarounds in a single >> place) >> >> I suppose to utilize it you need >> #include "utilities/globalDefinitions.hpp" >> It includes corresponding "globalDefinitions_*.hpp" depending on the >> compiler used. >> >> --alex >> >> On 12/07/2017 07:21, Langer, Christoph wrote: >>> Hi, >>> >>> please review the first extracted patch from 8192978. This one is >>> about correcting the jlong format string in >>> src/jdk.jdi/share/native/libdt_shmem/shmemBase.c. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8193183 >>> >>> WebRev: http://cr.openjdk.java.net/~clanger/webrevs/8193183.0/ >>> >>> I believe the libdt_shmem is only built on windows. >>> >>> Thanks, >>> >>> Christoph >>> >
