Done: http://hg.openjdk.java.net/jdk/jdk/rev/8ad12da0cbc7
Thanks Christoph From: Chris Plummer [mailto:chris.plum...@oracle.com] Sent: Freitag, 8. Dezember 2017 06:48 To: Langer, Christoph <christoph.lan...@sap.com>; serviceability-dev@openjdk.java.net; serguei.spit...@oracle.com Cc: Lindenmaier, Goetz <goetz.lindenma...@sap.com> Subject: Re: RFR (XS): 8193183: Fix format string in libdt_shmem/shmemBase.c Hi Christoph, Testing is done. All clear to push. I'll let you have the honors. :) Chris On 12/7/17 1:28 PM, Langer, Christoph wrote: Hi Chris, ok, I understand. Then please let me know when you’re done or …in that case you might as well do the push.:) Thanks Christoph From: Chris Plummer [mailto:chris.plum...@oracle.com] Sent: Donnerstag, 7. Dezember 2017 20:26 To: Langer, Christoph <christoph.lan...@sap.com><mailto:christoph.lan...@sap.com>; serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net>; serguei.spit...@oracle.com<mailto:serguei.spit...@oracle.com> Cc: Lindenmaier, Goetz <goetz.lindenma...@sap.com><mailto:goetz.lindenma...@sap.com> Subject: Re: RFR (XS): 8193183: Fix format string in libdt_shmem/shmemBase.c Hi Christoph, You can do the push, but please let me do some internal testing first. I want to make sure all our platforms are covered, and our closed tests are turn. thanks, Chris On 12/7/17 11:02 AM, Langer, Christoph wrote: Thanks Chris and Serguei for reviewing. I can do the push myself as it isn’t hotspot. I’ll send out other webrevs tomorrow for the other stuff. Best regards Christoph From: Chris Plummer [mailto:chris.plum...@oracle.com] Sent: Donnerstag, 7. Dezember 2017 19:14 To: Langer, Christoph <christoph.lan...@sap.com><mailto:christoph.lan...@sap.com>; serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net> Cc: Lindenmaier, Goetz <goetz.lindenma...@sap.com><mailto:goetz.lindenma...@sap.com> Subject: Re: RFR (XS): 8193183: Fix format string in libdt_shmem/shmemBase.c Looks good to me. I can sponsor the push for you. thanks, Chris On 12/7/17 7:21 AM, Langer, Christoph wrote: Hi, please review the first extracted patch from 8192978. This one is about correcting the jlong format string in src/jdk.jdi/share/native/libdt_shmem/shmemBase.c. Bug: https://bugs.openjdk.java.net/browse/JDK-8193183 WebRev: http://cr.openjdk.java.net/~clanger/webrevs/8193183.0/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8193183.0/> I believe the libdt_shmem is only built on windows. Thanks, Christoph
