It's best if you actually do the commit and then produce the patch with "hg export". Then the commit comment and user are setup already and all I need to do is "hg import <patch>; hg push".

thanks,

Chris

On 12/20/17 5:28 AM, Gary Adams wrote:
Is the patch file in the webrev sufficient?

http://bussund0416.us.oracle.com/export/users/gradams/work/webrevs/8180709/webrev.01/jdk-hs.patch

For testing I had been running the closed tonga all.testlist and the open jdk-tier1 tests.

But to demonstrate the error message, I would locally build "make profiles"
and then compare jre-compact2 and jre-compact3 results. The compact2
profile does not include java.instrument, but compact3 does.

On 12/19/17, 5:50 PM, Chris Plummer wrote:
I can push it this evening if no one else grabs it first (need to step out for a bit and won't be able to monitor CI results). Please produce a changeset first.

thanks,

Chris

On 12/19/17 2:47 PM, [email protected] wrote:
Now comes the catch ...
    I'll need a sponsor.



Reply via email to