Re: RFR: JDK-8180709: java -javaagent:agent.jar with run-time that does not contain java.instrument prints confusing error

[serguei.spit...@oracle.com]

Hi Gary, On 12/20/17 05:28, Gary Adams wrote: Is the patch file in the webrev sufficient?    http://bussund0416.us.oracle.com/export/users/gradams/work/webrevs/8180709/webrev.01/jdk-hs.patch For testing I had been running the closed tonga all.testlist and the open jdk-tier1 tests. Not sure, what coverage for j.l.instrument API is in the tonga tests. It seems, the only vm.defmeth has it. The :jdk_instrument (open/test/jdk/java/lang/instrument) test suite is what is normally needed. In this particular case any coverage might be enough though. :) Thanks, Serguei But to demonstrate the error message, I would locally build "make profiles" and then compare jre-compact2 and jre-compact3 results. The compact2 profile does not include java.instrument, but compact3 does. Good idea. I don't know how to run the mach5 for compact profiles. Most likely, your plan is to build and run tests locally. Thanks, Serguei On 12/19/17, 5:50 PM, Chris Plummer wrote: I can push it this evening if no one else grabs it first (need to step out for a bit and won't be able to monitor CI results). Please produce a changeset first. thanks, Chris On 12/19/17 2:47 PM, gary.ad...@oracle.com wrote: Now comes the catch ...     I'll need a sponsor.