Reviewed. Thanks, David
On 6/02/2018 3:56 PM, Shafi Ahmad wrote:
Hi, Could someone please review it. Regards, Shafi-----Original Message----- From: Shafi Ahmad Sent: Monday, January 29, 2018 6:02 PM To: serviceability-dev@openjdk.java.net Subject: [8u] RFR for 'JDK-8195088: [TEST_BUG] StartManagementAgent got unexpected exception' Hi, Please review the trivial code change for the fix of 'JDK-8195088: [TEST_BUG] StartManagementAgent got unexpected exception' to jdk8u-dev. Summary: This test case is expected to fail but the expected exception message is different. This fix - if (!ex.getMessage().contains("Invalid com.sun.management.jmxremote.port number")) { + if (!ex.getMessage().contains("NumberFormatException: For input string: \"apa\"")) { is checking for the correct message. This is fixed in jdk10 under bug JDK-8165736 [Error message should be shown when JVMTI agent cannot be attache] http://hg.openjdk.java.net/jdk/hs/rev/bc1cffa26561#l10.1 Jdk8 bug: https://bugs.openjdk.java.net/browse/JDK-8195088 webrev link: http://cr.openjdk.java.net/~shshahma/8195088/webrev.00/ Regards, Shafi
