Hi Stefan,
This change looks okay. Can you add a comment to describe the expected
memory pools for ZGC so that it explains why the min number of heap
memory pools is 1.
I think this test and possibly other memory pool tests should be
re-examined and determine what proper verification should be done, for
example, expected heap memory pools for a specific GC. It may be worth
to file a RFE to follow up.
Mandy
On 5/31/18 6:53 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to lower the minimum number of heap memory
pools in MemoryTest.java.
http://cr.openjdk.java.net/~stefank/8204173/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8204173
Just like the comment in the test says:
* NOTE: This expected result is hardcoded in this test and this test
* will be affected if the heap memory layout is changed in
* the future implementation.
*/
we need to update this test to support ZGC, which only has one heap
memory pool.
Thanks,
StefanK
