> On Jul 17, 2018, at 8:07 PM, mandy chung <mandy.ch...@oracle.com> wrote: > > > > On 7/17/18 7:00 AM, Bob Vandette wrote: >> Please review this fix which eliminates some docker/cgroup test failures >> when running on older >> Linux kernels with missing cgroup metric files. >> BUGS: >> https://bugs.openjdk.java.net/browse/JDK-8206456 >> WEBREV: >> http://cr.openjdk.java.net/~bobv/8206456/webrev/ > > Nit: It would be clearer to check for the specific metrics: > > int[] cpusets = metrics.getEffectiveCpuSetCpus(); > if (cpusets.length != 0) { > .... > } > > Same applies to getEffectiveCpuSetMems. No need for a new webrev.
Thanks, I’ll do that cleanup. > > Mandy > P.S. I am not sure the conversion from the primitive to boxed type > is necessary. But this is not related to this issue. You may > want to take a look at that. I’ll defer this issue to Harsha who wrote these tests since changing that is out of scope for this fix. Thanks, Bob.
