Thanks, JC! Alan, does webrev.01 look good to you?
-- Igor > On Feb 13, 2019, at 2:42 PM, Jean Christophe Beyler <jcbey...@google.com> > wrote: > > Hi Igor, > > Looks good to me :) > Jc > > On Wed, Feb 13, 2019 at 11:24 AM Igor Ignatyev <igor.ignat...@oracle.com > <mailto:igor.ignat...@oracle.com>> wrote: > Hi Alan, > > actually, String::join is enough in this case, uploaded webrev.01 -- > http://cr.openjdk.java.net/~iignatyev//8209455/webrev.01 > <http://cr.openjdk.java.net/~iignatyev//8209455/webrev.01> > > Thanks, > -- Igor > >> On Feb 12, 2019, at 11:04 PM, Alan Bateman <alan.bate...@oracle.com >> <mailto:alan.bate...@oracle.com>> wrote: >> >> On 13/02/2019 00:01, Igor Ignatyev wrote: >>> http://cr.openjdk.java.net/~iignatyev//8209455/webrev.00 >>> <http://cr.openjdk.java.net/~iignatyev//8209455/webrev.00> >>>> 2 lines changed: 0 ins; 0 del; 2 mod; >>> >>> Hi all, >>> >>> could you please review this trivial cleanup which replaces StringBuffer by >>> StringBuilder in jdk.management.agent module? >>> >>> webrev: http://cr.openjdk.java.net/~iignatyev/8209455/webrev.00/ >>> <http://cr.openjdk.java.net/~iignatyev/8209455/webrev.00/> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8209455 >>> <https://bugs.openjdk.java.net/browse/JDK-8209455> >>> >> Looks okay but StringJoiner might be better here. >> >> -Alan > > > > -- > > Thanks, > Jc
