Hi Dmitry,
On 1/03/2019 6:15 am, Dmitry Chuyko wrote:
Hello,
Please review a small fix for GCC 8.x warning in log_messages.c. Buffer
sizes for parts of timestamp string can be adjusted to not exceed
maximum buffer size when combined, while being able to hold necessary
information.
webrev: http://cr.openjdk.java.net/~dchuyko/8214854/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-8214854
testing: after the fix GCC 8 compiles working OpenJDK on Linux.
Dev-submit job started.
This looks good.
One query:
51 typedef char timestamp_buffer[TIMESTAMP_SIZE];
Is this needed so that the size of the buffer is known by gcc inside
get_time_stamp? (Generally I prefer to see explicitly when an array is
being stack allocated, not have it hidden behind a typedef.)
Thanks,
David
-Dmitry
