Hi Jean Christophe, On 15/03/2019 22:47, Jean Christophe Beyler wrote:
Not a reviewer but looks good to me :) I would perhaps put a comment above the argument creation to note that the order is important, ie something like: "// Need to add the default arguments first to have explicit -Xmx8g last, otherwise test will fail."
Thanks. I've added this to the webrev: http://cr.openjdk.java.net/~ngasson/8220707/webrev.1/ Nick