Hi Nick, this is great, thank you for fixing this, +1😊
We ran into the same problem when we were trying to set different default Xmx options in our test infrastructure for small machines where the default heaps would be too small by default. My colleague Arno had the very same patch on his ToDo list already. Best regards Christoph > -----Original Message----- > From: serviceability-dev <serviceability-dev-boun...@openjdk.java.net> On > Behalf Of Nick Gasson > Sent: Mittwoch, 27. März 2019 04:20 > To: Sharath Ballal <sharath.bal...@oracle.com>; serviceability- > d...@openjdk.java.net > Subject: Re: RFR(XS): 8220707: [TESTBUG] > serviceability/sa/TestHeapDumpForLargeArray.java fails with jtreg - > vmoption:-Xmx < 8g > > Hi, > > Could I get another reviewer to look at this please? > > Thanks! > Nick > > > On 18/03/2019 18:04, Nick Gasson wrote: > > Hi Sharath, > > > > On 15/03/2019 23:32, Sharath Ballal wrote: > >> > >> Fix looks good. How have you tested it ? > > > > I ran the test using the "make test" target with and without > > JTREG="MAX_MEM=512m" on AArch64 and x86. Previously it would fail > with > > that argument. > > > > Thanks, > > Nick
