On 03/10/2019 00:47, serguei.spit...@oracle.com wrote: > Hi Severin, > > It looks good and applies cleanly. > So, I'm not sure you really need a review for this. > > Thanks, > Serguei > > On 10/1/19 06:01, Severin Gehwolf wrote: >> Hi, >> >> Please review this OpenJDK 8u vs. Oracle JDK 8 parity patch. I wasn't >> sure whether I need review for this one as the bug in question is a JDK >> 8-only bug and the patch applies as-is. Anyway, here it is: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8195088 >> webrev: >> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8195088/01/webrev/ >> >> Testing: StartManagementAgent.java test fails prior and passes after >> this patch. >> >> Thoughts? >> >> Thanks, >> Severin >> >
What "applies cleanly"? As far as I can see, this is part of JDK-8165736. As the rest of 8165736 is not being applied, then yes, it needs review. Approved. I'll push it as part of b05. Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 https://keybase.io/gnu_andrew
signature.asc
Description: OpenPGP digital signature
