Hi Igor,
89 log.display("Connector's transport is: " +
c.transport().name());
Would be nice if you printed each transport's name (even the skipped
ones). That way when reading the log after getting SkippedException you
can see which transports were attempted.
You removed the following:
50 * ================================================
51 * WARNING:
52 * Temporarily the test is prepared only for
53 * Sparc.Solaris.dt_socket-transport of RawCommandLineLaunch
54 * connector
55 * ================================================
Isn't this still somewhat true? It's still requires dt_socket, but no
longer solaris-sparc. This is part of the reason I asked above to print
which transports are attempted. I'm curious what the skipped transport
is on Windows.
thanks,
Chris
On 4/9/20 2:43 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev/8242471/webrev.00/
38 lines changed: 8 ins; 23 del; 7 mod;
Hi all,
could you please review this small patch for nsk/jdi/Argument/value/value004
test?
from JBS:
nsk/jdi/Argument/value/value004 test has restrictions to be run only on
solaris-sparc and w/ dt_socket transport, solaris-sparc restriction seems to be
not valid any more. the test also should be updated to use skipped exception if
there are no suitable connectors available.
JBS: https://bugs.openjdk.java.net/browse/JDK-8242471
testing: the changed test on {linux,windows,macosx}-x64 and solaris-sparcv9, w/
the test being skipped on windows-x64
webrev: http://cr.openjdk.java.net/~iignatyev/8242471/webrev.00/
Thanks,
-- Igor
