make, test, doc, and bin all have .js files. I was counting them in them also. 36 total files (not 36 directories).
thanks,
Chris
On 5/27/20 8:12 PM, sundararajan.athijegannat...@oracle.com wrote:
Hi Chris,
Note that not all .js files are related to nashorn!
* The one in java.scripting module is init.js file used by jrunscript tool. The jrunscript is javax.script based scripting language independent shell tool. It uses init.js script if the underlying language engine happens to be '_javascript_'. This tool still exists and can use js engine if user drops suitable js engine jar in classpath/modulepath.
* The ones in jdk.javadoc are used in the browser (jquery, search.js). There is a script to test javadoc's search feature. The test looks for js engine before using the test. Developer can drop another js engine and run the test.
PS. "find . -name *.java" found only 10 .js paths in "jdk/src" directory.36 directories?
Thanks-Sundar
On 27/05/20 10:08 pm, Chris Plummer wrote:
Hi Serguei,
Possibly those should be deleted, but not as part of the removal of JS support from SA. They are for .js files in src/java.scripting, src/jdk.javadoc, and src/jdk.dev. There are no longer any .js files in src/jdk.dev, but there are in the other two directories. There are bunch more in other directories not listed, 36 in total. I'm guessing that some should have been removed when Nashorn was removed. Maybe Sundar can comment on this.
thanks,
Chris
On 5/27/20 1:56 AM, serguei.spit...@oracle.com wrote:
Hi Chris,
A couple of questions.
http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/make/CompileJavaModules.gmk.udiff.html-jdk.hotspot.agent_COPY += .gif .png sa.js .properties +jdk.hotspot.agent_COPY += .gif .png .propertiesThere are more occurrences of the .js in that file:
215 java.scripting_COPY += .js 346 jdk.javadoc_COPY += .xml .css .js .png 416 jdk.dev_COPY += .js oqlhelp.html .txtShould all these be deleted?
Otherwise, looks good.
No need in another webrev.
Thanks,
Serguei
On 5/26/20 19:42, sundararajan.athijegannat...@oracle.com wrote:
Looks good to me.
-Sundar
On 27/05/20 5:01 am, Chris Plummer wrote:
Hello,
Please review the following changes to fully remove _javascript_ support from SA. It's been non-functional since JDK 9 and there are no plans to support it anymore.
https://bugs.openjdk.java.net/browse/JDK-8244668
http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/index.html
If anyone thinks a CSR is needed for this, please let me know. There's no spec involved. The support was always pretty ad hoc, with some supporting documentation in the source tree in jsdb.html [1], but which doesn't appear itself to have ever been released.
There was one menu item in the hsdb GUI that used _javascript_ (and as a result caused an exception). I was having a little trouble deciphering what it actually does, but it appears to allow you to write some _javascript_ to produce (and filter) a list of objects, and then display the list of objects in a window where you could inspect them further. Since there is no way to do something similar in java without allowing the user to provide hsdb extensions in the form of .class files (or support writing and compiling java classes from within hsdb), I just removed the hsdb feature by removing the menu item and supporting code.
thanks,
Chris
[1] https://hg.openjdk.java.net/jdk/jdk/raw-file/a7e42c260029/src/jdk.hotspot.agent/doc/jsdb.html
