On Mon, 14 Sep 2020 16:47:27 GMT, Daniel D. Daugherty <dcu...@openjdk.org> wrote:
>> @rkennke - I've commited the changes in your webrev as >> https://github.com/openjdk/jdk/pull/135/commits/bbf8dbd09bdf5c1c77c67cc637fbc10fe72d4894. > > @dholmes-ora and @fisk - I've taken a first pass at creating a CSR: > JDK-8253121 migrate ObjectMonitor::_object to OopStorage > https://bugs.openjdk.java.net/browse/JDK-8253121 > > Please look it over and feel free to edit as needed. Since I don't do > CSR's often, what I've done might be all wrong. :-) @kimbarrett: > src/hotspot/share/oops/weakHandle.cpp > 36 WeakHandle::WeakHandle(OopStorage* storage, oop obj) : > 37 _obj(storage->allocate()) { > 38 assert(obj != NULL, "no need to create weak null oop"); > > Please format this differently so the ctor-init-list is more easily > distinguished from the body. I don't care that much which of the several > alternatives is used. After discussion with Erik, I changed the indent on L37 from two space to four spaces. ------------- PR: https://git.openjdk.java.net/jdk/pull/135
