> On Sep 14, 2020, at 2:39 PM, Daniel D.Daugherty <dcu...@openjdk.java.net>
> wrote:
>
> On Mon, 14 Sep 2020 18:33:17 GMT, Daniel D. Daugherty <dcu...@openjdk.org>
> wrote:
>
>> @kimbarrett:
>>
>>> src/hotspot/share/oops/weakHandle.cpp
>>> 36 WeakHandle::WeakHandle(OopStorage* storage, oop obj) :
>>> 37 _obj(storage->allocate()) {
>>> 38 assert(obj != NULL, "no need to create weak null oop");
>>>
>>> Please format this differently so the ctor-init-list is more easily
>>> distinguished from the body. I don't care that much which of the several
>>> alternatives is used.
>>
>> After discussion with Erik, I changed the indent on L37 from two space to
>> four spaces.
>
> @kimbarrett
Thanks. That’s one of the “several alternatives” I was alluding to.
