On Fri, 18 Sep 2020 19:46:34 GMT, Daniel D. Daugherty <dcu...@openjdk.org>
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 691:
>
>> 689: // Note:
>> 690: // calling_thread is the thread that requested the list of monitors
>> for java_thread.
>> 691: // java_thread is thread owning the monitors.
>
> s/is thread/is the thread/
Fixed
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 692:
>
>> 690: // calling_thread is the thread that requested the list of monitors
>> for java_thread.
>> 691: // java_thread is thread owning the monitors.
>> 692: // current_thread is thread executint this code, can be a
>> non-JavaThread (e.g. VM Thread).
>
> typo - s/executint/executing/
> grammar - s/e.g./e.g.,/
Fixed
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 693:
>
>> 691: // java_thread is thread owning the monitors.
>> 692: // current_thread is thread executint this code, can be a
>> non-JavaThread (e.g. VM Thread).
>> 693: // And they all maybe different threads.
>
> typo - (in this context) - s/maybe/may be/
Fixed
> src/hotspot/share/prims/jvmtiEnvBase.hpp line 341:
>
>> 339: class JvmtiHandshakeClosure : public HandshakeClosure {
>> 340: protected:
>> 341: jvmtiError _result;
>
> Thanks for pushing the jvmtiError into common code for JVM/TI handshakes.
Thanks
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 653:
>
>> 651: JvmtiEnvBase::get_current_contended_monitor(JavaThread *calling_thread,
>> JavaThread *java_thread,
>> jobject *monitor_ptr) { 652: Thread *current_thread = Thread::current();
>> 653: assert(java_thread->is_handshake_safe_for(current_thread),
>
> I like how this assert reads now!
Great!
-------------
PR: https://git.openjdk.java.net/jdk/pull/151
