On Fri, 18 Sep 2020 20:21:09 GMT, Daniel D. Daugherty <dcu...@openjdk.org>
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/handshake.cpp line 349:
>
>> 347: target->handshake_state()->add_operation(op);
>> 348: } else {
>> 349: log_handshake_info(start_time_ns, op->name(), 0, 0, "(thread
>> dead)");
>
> It might be useful to also log the 'target' thread value here so:
>
> .... (thread=<ptr-value> is dead)"
>
> Might be something like this:
>
> log_handshake_info(start_time_ns, op->name(), 0, 0, "(thread=" INTPTR_FORMAT
> " is dead)", p2i(target));
>
> Although you'd probably have to form the string in a buffer and then pass it
> to the log_handshake_info() call... sigh...
Fixed (via buffert)
> src/hotspot/share/runtime/handshake.cpp line 450:
>
>> 448: return false;
>> 449: }
>> 450: // Operations are added without lock and then the poll is armed.
>
> s/without lock/lock free/
Fixed
> src/hotspot/share/runtime/handshake.cpp line 479:
>
>> 477: }
>> 478:
>> 479: // If we own the mutex at this point and while owning the mutex
>
> grammar - s/owning the mutex/owning the mutex we/
Fixed
-------------
PR: https://git.openjdk.java.net/jdk/pull/151
