On Tue, 29 Sep 2020 14:43:30 GMT, Igor Ignatyev <iignat...@openjdk.org> wrote:

>> The changes look good, but I think the practice of doing a massive cleanup 
>> in "remove usage of PropertyResolvingWrapper
>> in vmTestbase/nsk/jdb" PR is misleading. Better to split this in two issues 
>> (at least next time)?
>
> @shipilev , do you have any further comments? Or are you (relatively) happy 
> w/ the patch after the last 3 commits?

I have to push back on this. Needs to be broken up. You have 3 large changes 
that are completely unrelated. Seems you
can push any of those 3 independent of the others.

-------------

PR: https://git.openjdk.java.net/jdk/pull/350

Reply via email to