On Tue, 29 Sep 2020 21:06:58 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

> I have to push back on this. Needs to be broken up. You have 3 large changes 
> that are completely unrelated. Seems you
> can push any of those 3 independent of the others.

Hi Chris,

what do you see as a 3rd change here?

`removes PropertyResolvingWrapper from vmTestbase/nsk/jdb tests` and `updates 
JdbArgumentHandler to remove " from
jdb.option option` parts aren't independent. the only independent part is code 
reformating, which, at least in my book,
would include moving var declaration. so if you insist I can split into two 
patches:
[5f62042](https://github.com/openjdk/jdk/pull/350/commits/5f62042817700b1240cbbd29a56523eb00b6b084)
 (+ copyright year
updates if any) and the rest.

-- Igor

-------------

PR: https://git.openjdk.java.net/jdk/pull/350

Reply via email to