On Thu, 1 Oct 2020 16:37:11 GMT, Ziviani <[email protected]> wrote:
> > If these tests are currently passing with Jose's fix, I suggest to comment > > them out in the problem list with a note > > that we may need to disable them again because of JDK-8230664. This way we > > can test the functionality Jose is fixing > > until then. And we'll see when the issue comes up again. > > Done! Please, check if you're fine with this: > > ``` > +# The solution to bug JDK-8253900 seems to fix tests TestInstanceKlassSize > and > +# TestInstanceKlassSizeForInterface. However, while JDK-8230664 is not > resolved, > +# these tests may be disabled again if necessary. > +# serviceability/sa/TestInstanceKlassSize.java 8230664 > linux-ppc64le,linux-ppc64 > +# serviceability/sa/TestInstanceKlassSizeForInterface.java 8230664 > linux-ppc64le,linux-ppc64 > ``` I don't believe there are any other cases were we comment out a test in a problem list. I think it would be best just to remove it completely from ProblemList.txt. JDK-8230664 will still be filed. I suggest maybe adding a comment there saying that the test was removed from the problem list when JDK-8253900 was fixed, but should be re-added if JDK-8230664 starts to reproduce again. ------------- PR: https://git.openjdk.java.net/jdk/pull/358
