On Mon, 9 Nov 2020 19:02:41 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Thanks for review, @kvn! I would also like a review from someone from >> serviceability. > > Friendly reminder. Hi Aleksey, I've not looked at the compiler generated code. The fix looks okay to me. I have a question and a couple of minor suggestions on new test. Q: Why the value of ITERS is that big? What is the need to have this number of iterations? Also, I do not like one-letter identifiers, especially if they are not local. Could you, please, replace identifiers R and A with some short versions that give a hint. Something like REFSIZE and ALIGNMENT would be good enough. Also, what tests did you run to make sure no regression is introduced? Thanks, Serguei ------------- PR: https://git.openjdk.java.net/jdk/pull/650
