On Wed, 20 Jan 2021 20:28:34 GMT, Vladimir Kozlov <k...@openjdk.org> wrote:
>> Igor Veresov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Check legacy flags validity before deriving flag values for emulation mode. > > src/hotspot/cpu/aarch64/c1_LIRGenerator_aarch64.cpp line 1414: > >> 1412: // use LD;DMB but stores use STLR. This can happen if C2 compiles >> 1413: // the stores in one method and C1 compiles the loads in another. >> 1414: if (!CompilerConfig::is_c1_or_interpreter_only_no_aot_or_jvmci()) { > > It is C1 code which should not be executed in -Xint. Why check > `interpreter_only`? Good point, I'll fix that. > src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp > line 54: > >> 52: ShenandoahBarrierSet::assembler()->cmpxchg_oop(masm->masm(), addr, >> cmpval, newval, /*acquire*/ true, /*release*/ true, /*is_cae*/ false, >> result); >> 53: >> 54: if (CompilerConfig::is_c1_or_interpreter_only_no_aot_or_jvmci()) { > > Again about `interpreter_only` check. Fixed. ------------- PR: https://git.openjdk.java.net/jdk/pull/1985