On Tue, 19 Jan 2021 21:59:16 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Lin Zang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix issue of setting gz option with no value > > I think you need to add some additional testing. You can use > ClhsdbDumpheap.java and also BasicJMapTest.java. Besides testing with a > compressed hprof file, also add a test for "gz=" with no compression value > and with invalid compression value. Hi @plummercj, I have done some fixes related to gziped heap dump and add several subtests. May I ask your help to review again? Thanks! Lin ------------- PR: https://git.openjdk.java.net/jdk/pull/1712