On Sun, 24 Jan 2021 21:10:56 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - Merge >> - 1. Prperly reverted fixes in 3 tests; 2. Got rid of <inherited> term in >> tests summary comment >> - @summary of some negative tests is corrected >> - 1. Suppress premain method check only if agent class is in unnamed >> module; 2. minor tests cleanup >> - added to NegativeAgentRunner exit value check to be non-zero >> - 1. Replaced AgentJarBuilder with JavaAgentBuilder; 2. Removed unneeded >> sun.tools.jar imports >> - fixed trailing spaces >> - (1) Update premain/agentmain method lookup; (2) refactored tests to get >> rid of shell scripts >> - added 8165276 to @bug list of impacted tests >> - (1)Fix comment in InstrumentationImpl; (2) Update agent super classes in >> tests with new expectations that premain methods in supers should non be >> called >> - ... and 2 more: >> https://git.openjdk.java.net/jdk/compare/77ea10ca...d926e4b1 > > Hi Serguei, > > This seems good to go. > > Thanks, > David Thank you for review, David! ------------- PR: https://git.openjdk.java.net/jdk/pull/1694
