On Wed, 27 Jan 2021 23:54:58 GMT, Lin Zang <lz...@openjdk.org> wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump > > Lin Zang has updated the pull request incrementally with one additional > commit since the last revision: > > fix the logic of using gz= as file name You added clhsdb testing to ClhsdbDumpheap.java, but I had also suggested adding testing to BasicJMapTest.java to test pmap. Can you please add some testing there also? src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java line 1821: > 1819: usage(); > 1820: return; > 1821: } Isn't this check only needed at the end of the `cntTokens == 2` section? If there is just one token and it starts with `gz=`, it will be caught by `parseHeapDumpCompressionLevel`. ------------- PR: https://git.openjdk.java.net/jdk/pull/1712
