On Wed, 3 Feb 2021 22:17:03 GMT, Alex Menkov <[email protected]> wrote:

>> The test expects debuggee output in jdb output stream.
>> But jdb redirects debuggee output asynchronously so sometimes it's 
>> incomplete or mixed with jdb output.
>> The fix updates debuggee to print output to file and read/analyze it after 
>> jdb (and debuggee) exits.
>
> Alex Menkov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   separated debuggee class name and args

Hi Alex,
It looks good to me.
I liked previous variant as well.
It looks a little bit strange to duplicate the same  pattern on many lines:
  "targ + outFileArg"
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2322

Reply via email to