On Wed, 3 Feb 2021 22:17:03 GMT, Alex Menkov <[email protected]> wrote:

>> The test expects debuggee output in jdb output stream.
>> But jdb redirects debuggee output asynchronously so sometimes it's 
>> incomplete or mixed with jdb output.
>> The fix updates debuggee to print output to file and read/analyze it after 
>> jdb (and debuggee) exits.
>
> Alex Menkov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   separated debuggee class name and args

test/jdk/com/sun/jdi/JdbOptions.java line 91:

> 89:         // the simplest case
> 90:         test("-connect",
> 91:                 
> "com.sun.jdi.CommandLineLaunch:vmexec=java,options=-client 
> -XX:+PrintVMOptions,main=" + targ + outFileArg)

Not to be too nit picky, but I was assuming that the " " would be here and not 
in outFileName. That would make it much more obvious how the args are separated 
(eg we are not using commas here).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2322

Reply via email to