On Sun, 7 Mar 2021 07:32:17 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:

> We can command line debugger via "Windows" -> "Console" menu on HSDB. If the 
> command shows error message in localized string (e.g. Japanese), it might 
> garble as following:
> 
> ![garbled](https://user-images.githubusercontent.com/7421132/110232635-39e89b00-7f62-11eb-95c9-1a5238072814.png)
> 
> Command line debugger and Debugger Console (WinDbg on Windows) will use 
> Courier font on their console, but it does not show Japanese chars. I guess 
> it would happen on CJK chars because monospaced font for Chinese, Japanese, 
> Korean are different from Courier.
> 
> After this change on Windows which set to Japanese locale, it uses MS Gothic 
> and we can see localized message as following:
> 
> ![fixed](https://user-images.githubusercontent.com/7421132/110232699-a4014000-7f62-11eb-9185-6eff39394541.png)

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/CommandProcessorPanel.java
 line 63:

> 61:         editor = new JTextArea();
> 62:         editor.setDocument(new EditableAtEndDocument());
> 63:         editor.setFont(new Font(Font.MONOSPACED, Font.PLAIN, 
> GraphicsUtilities.FONT_SIZE));

Maybe this can be changed to `GraphicsUtilities.getMonospacedFont()` so there's 
no need to export FONT_SIZE?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2862

Reply via email to