On Wed, 31 Mar 2021 19:57:57 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> This function is used to call the classfile parser for hidden or anonymous
>> classes, and for use with jvmti RedefineClasses. The latter only calls
>> KlassFactory::create_from_stream and skips the rest of the code in
>> SystemDictionary::parse_stream.
>>
>> Renamed SystemDictionary::parse_stream -> resolve_hidden_class_from_stream
>> resolve_from_stream -> resolve_class_from_stream
>> and have SystemDictionary::resolve_from_stream() call the right version
>> depending on ClassLoadInfo flags. Callers of resolve_from_stream now pass
>> protection domain via. ClassLoadInfo.
>>
>> So the external API is resolve_from_stream.
>>
>> Tested with tier1 on 4 Oracle supported platforms.
>
> Coleen Phillimore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fifix comment
Nice clean up Coleen. One minor comment.
Thanks,
Lois
src/hotspot/share/prims/jvm.cpp line 950:
> 948: InstanceKlass* ik = NULL;
> 949: if (!is_hidden) {
> 950: ClassLoadInfo cl_info(protection_domain);
Minor comment, you could pull the creation of ClassLoadInfo out of this if
statement since both the the if and the else sections create a ClassLoadInfo
with pretty much the same information.
-------------
Marked as reviewed by lfoltan (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3289
