On Wed, 31 Mar 2021 19:57:57 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> This function is used to call the classfile parser for hidden or anonymous >> classes, and for use with jvmti RedefineClasses. The latter only calls >> KlassFactory::create_from_stream and skips the rest of the code in >> SystemDictionary::parse_stream. >> >> Renamed SystemDictionary::parse_stream -> resolve_hidden_class_from_stream >> resolve_from_stream -> resolve_class_from_stream >> and have SystemDictionary::resolve_from_stream() call the right version >> depending on ClassLoadInfo flags. Callers of resolve_from_stream now pass >> protection domain via. ClassLoadInfo. >> >> So the external API is resolve_from_stream. >> >> Tested with tier1 on 4 Oracle supported platforms. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > fifix comment src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 1395: > 1393: cl_info, > 1394: THREAD); > 1395: Could you add a comment above line 1390 saying you can't call resolve_class_from_stream() here because the resulting class should not go in the system dictionary? ------------- PR: https://git.openjdk.java.net/jdk/pull/3289
