On Wed, 21 Apr 2021 05:56:21 GMT, Lin Zang <lz...@openjdk.org> wrote:
> > My concerns with your proposed testing is that it always targets the same > > application with the same heap, and does not read/process the hprof file to > > make sure it is not corrupt. > > Hmm, I agree, I will do more test and update here. Thanks! As for jtreg testing, we have a few heap dumping related tests. I'm not sure how good they are. It would be good to understand what testing we currently do. In addition to jtreg testing, you might want to try just launching some large java apps (netbeans and intellij come to mind), dump their heaps, and then process them with some existing tool. I'm not suggesting this be part of regular testing, but just a sanity check you do on your own before pushing the changes. ------------- PR: https://git.openjdk.java.net/jdk/pull/2261
