On Wed, 21 Apr 2021 18:40:16 GMT, Chris Plummer <[email protected]> wrote:
>>> My concerns with your proposed testing is that it always targets the same
>>> application with the same heap, and does not read/process the hprof file to
>>> make sure it is not corrupt.
>>
>> Hmm, I agree, I will do more test and update here. Thanks!
>
>> > My concerns with your proposed testing is that it always targets the same
>> > application with the same heap, and does not read/process the hprof file
>> > to make sure it is not corrupt.
>>
>> Hmm, I agree, I will do more test and update here. Thanks!
>
> As for jtreg testing, we have a few heap dumping related tests. I'm not sure
> how good they are. It would be good to understand what testing we currently
> do.
>
> In addition to jtreg testing, you might want to try just launching some large
> java apps (netbeans and intellij come to mind), dump their heaps, and then
> process them with some existing tool. I'm not suggesting this be part of
> regular testing, but just a sanity check you do on your own before pushing
> the changes.
Hi Chris, @plummercj
Here are the tests I have conducted:
- tier1, tier2,tier3 all passed
- netbeans with heap usage of 500mb, 1000mb, plus "randomly do some
operation and dump the heap". tested 30 times and all passed.
- a workload that generate different object to fill heap, I have tested
with heap usage from 1GB to 8GB. All passed.
All the scenario are tested with/without the gz option.
Do you think these tests are ok?
BRs,
Lin
-------------
PR: https://git.openjdk.java.net/jdk/pull/2261
