> findComponentType() logic is wrong. In findComponentType() method, We always 
> get vm.classesByName() retruns empty list
> list = vm.classesByName(parser.typeName());
> We have "parser.typeName()" retruns " double[][]"
> vm.classesByName("") is expecting the fully qualified name example 
> "java.lang.Double"
> This always returns empty list, resulting into ClassNotLoadedException as it 
> assumes the Component class has not yet been loaded, hence the test case 
> fails.
> 
> There was a suggested fix from Egor Ushakov from JetBrains, I am proposing 
> the same to get this fix. I have verified the patch with required testing it 
> works fine.

Fairoz Matte has updated the pull request incrementally with two additional 
commits since the last revision:

 - Update ArrayReferenceImpl.java
 - Update ArrayTypeImpl.java

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3658/files
  - new: https://git.openjdk.java.net/jdk/pull/3658/files/17fe300c..37170d21

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3658&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3658&range=00-01

  Stats: 17 lines in 2 files changed: 0 ins; 13 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3658.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3658/head:pull/3658

PR: https://git.openjdk.java.net/jdk/pull/3658

Reply via email to