On Tue, 6 Jul 2021 02:55:37 GMT, Lin Zang <[email protected]> wrote: > The current implementation of hprof Reader for testing always prompts "Can > not decompress the compressed hprof file" when there is error for testing > gzipped heap dump. This is inaccurate if the gzipped file was decompressed > successfully but the hprof file format is incorrect. So the inaccurate error > message could be misleading for issue analysis. > > This trivial PR refine the error message by simply print "Can not get stack > trace from the compressed hprof file", the underlying exception from > GZIPInputStream() or HprofReader() would give accurate error info.
The existing message is a generic message covering the general operation of the whole try block. It seems far more appropriate than your new message, which only seems to apply to the final step. ??? David ------------- PR: https://git.openjdk.java.net/jdk/pull/4685
