> The current implementation of hprof Reader for testing always prompts "Can 
> not decompress the compressed hprof file" when there is error for testing 
> gzipped heap dump. This is inaccurate if the gzipped file was decompressed 
> successfully but the hprof file format is incorrect. So the inaccurate error 
> message could be misleading for issue analysis.
> 
> This trivial PR refine the error message by simply print "Can not get stack 
> trace from the compressed hprof file", the underlying exception from 
> GZIPInputStream() or HprofReader() would give accurate error info.

Lin Zang has updated the pull request incrementally with one additional commit 
since the last revision:

  divid the try block

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4685/files
  - new: https://git.openjdk.java.net/jdk/pull/4685/files/4ee240f6..76a69c38

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4685&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4685&range=00-01

  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4685.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4685/head:pull/4685

PR: https://git.openjdk.java.net/jdk/pull/4685

Reply via email to