On Tue, 13 Jul 2021 01:25:48 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Subset of RawMonitor; comments added > > I can understand that raw_enter and raw_wait need this fix because they have > the ThreadBlockInVM transition; but why do we need it for raw_exit and > raw_notify when they do not change the thread state ?? @dholmes-ora I added the W^X into all RawMonitor functions since they clearly slipped from the common JVMTI entry with W^X management. It was just precaution. But I don't see any problem with handling only raw_enter and raw_wait, updated the patch. Handling only subset of functions also simplifies the comment suggested by @sspitsyn. Thanks for the comments! ------------- PR: https://git.openjdk.java.net/jdk17/pull/244
