On Tue, 13 Jul 2021 10:13:39 GMT, Anton Kozlov <akoz...@openjdk.org> wrote:
>> The change adds W^X transition in RawMonitor family of functions, fixing the >> crash. RawMonitor functions are treated specially, so W^X transition is not >> inserted automatically. A better fix would be in .xml description for >> entries generation, but for now it is too risky. I hope to get this fixed in >> 17 in the simplest way and do re-work in the 18. This change is still 100% >> correct for the reported bug. >> >> Verified by: >> >> jtreg -vmoption:-XX:+AssertWXAtThreadSync >> test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 > > Anton Kozlov has updated the pull request incrementally with one additional > commit since the last revision: > > Subset of RawMonitor; comments added OK. We really need to have a think about how W^X should be handled: this temporal coupling is a code smell, and will be be a reliability problem until we do something better. ------------- Marked as reviewed by aph (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/244
