On Fri, 17 Sep 2021 08:24:54 GMT, Lin Zang <lz...@openjdk.org> wrote:

> The class `GzipRandomAccess` is used to parse heap dump file generated from 
> `jcmd`/`jmap` tools when testing.
> It has the limitation that only gzip file which has "blocksize" header field 
> could be sucessfully parsed.
> We think this class can be removed for 2 reasons:
> 1. The gzip heap dump file generated by `jhsdb` command does not contain the 
> "blocksize" header field, so the GzipRandomAccess can not parse the generated 
> file successfully.
> 2. The `GzipInputStream` could be used instead and then gziped heap dump file 
> generated from both `jcmd`/`jmap` and `jhsdb jmap` could be parsed using same 
> logic.
> Options

Marked as reviewed by sspitsyn (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5556

Reply via email to