On Fri, 17 Sep 2021 08:24:54 GMT, Lin Zang <lz...@openjdk.org> wrote:
> The class `GzipRandomAccess` is used to parse heap dump file generated from > `jcmd`/`jmap` tools when testing. > It has the limitation that only gzip file which has "blocksize" header field > could be sucessfully parsed. > We think this class can be removed for 2 reasons: > 1. The gzip heap dump file generated by `jhsdb` command does not contain the > "blocksize" header field, so the GzipRandomAccess can not parse the generated > file successfully. > 2. The `GzipInputStream` could be used instead and then gziped heap dump file > generated from both `jcmd`/`jmap` and `jhsdb jmap` could be parsed using same > logic. > Options This pull request has now been integrated. Changeset: 340c715c Author: Lin Zang <lz...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/340c715c3b0f5ad5204f9dddb17a787b07426543 Stats: 578 lines in 2 files changed: 0 ins; 578 del; 0 mod 8273929: Remove GzipRandomAccess in heap dump test Reviewed-by: cjplummer, sspitsyn ------------- PR: https://git.openjdk.java.net/jdk/pull/5556
