On Tue, 5 Oct 2021 22:34:38 GMT, Alex Menkov <amen...@openjdk.org> wrote:

> The change fixes ProcessTools.startProcess "warmup predicate" synchronization 
> issue.
> Initially the predicate was called only for STDOUT;
> From jdk8 it's called for STDERR too (but ProcessTools javadoc was not 
> updated).
> The fix keeps existing functionality as is (as we have this behavior for a 
> long time and we have tests which expect STDERR output), but adds 
> synchronization to avoid calling predicate after previous call returned 
> "true".
> Also updated javadoc to reflect actual behavior.

Looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5830

Reply via email to