On Tue, 19 Oct 2021 21:52:14 GMT, Ioi Lam <ik...@openjdk.org> wrote:

>>> Hi Jacob, this is not your fault, but the "zz help text" in the Chinese and 
>>> Japanese versions are in a single huge line. This makes it impossible to 
>>> see what you have changed in the GitHub diffs, and impossible to tell 
>>> whether you made any typos in the process.
>> 
>> I'd suggest you just undo the change. As mentioned earlier, localization is 
>> not your responsibility, and this lack of localization won't cause jdb to 
>> not run properly. It will just be missing some help text.
>
>> > Hi Jacob, this is not your fault, but the "zz help text" in the Chinese 
>> > and Japanese versions are in a single huge line. This makes it impossible 
>> > to see what you have changed in the GitHub diffs, and impossible to tell 
>> > whether you made any typos in the process.
>> 
>> I'd suggest you just undo the change. As mentioned earlier, localization is 
>> not your responsibility, and this lack of localization won't cause jdb to 
>> not run properly. It will just be missing some help text.
> 
> Sounds good to me, too. Just remember to file a bug to update the localized 
> text.

Okay, looks like Skara still needs this to be marked as reviewed before I can 
integrate it.  @iklam and @plummercj, would one or both of you be able to 
fulfill that requirement if no more changes are needed here?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5290

Reply via email to